Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.13.5 #93

Closed
wants to merge 2 commits into from
Closed

Release 1.13.5 #93

wants to merge 2 commits into from

Conversation

glensc
Copy link
Contributor

@glensc glensc commented Aug 7, 2021

Prepare release using #92

@glensc
Copy link
Contributor Author

glensc commented Aug 7, 2021

CI jobs all fail with no output at all.

@glensc glensc mentioned this pull request Aug 7, 2021
32 tasks
@glensc
Copy link
Contributor Author

glensc commented Aug 7, 2021

Draft for changelog

@falkenhawk
Copy link
Member

hi @glensc thank you for the reminder, I'll take care of this once I catch up after my vacation break. Apologies for extended wait time.

@glensc
Copy link
Contributor Author

glensc commented Aug 9, 2021

@falkenhawk just don't lose my commits here. i've spent quite a time to build the changelog

@falkenhawk
Copy link
Member

CI jobs all fail with no output at all.

They fail because of No runner matching the specified labels was found: ubuntu-16.04
actions/runner-images#3287

The ubuntu-16.04 env was supposed to be removed in September, but for some reason it already stopped working here

@glensc glensc mentioned this pull request Aug 11, 2021
@glensc
Copy link
Contributor Author

glensc commented Aug 11, 2021

Ok, let's switch the image then:

@falkenhawk
Copy link
Member

@glensc would it make sense to make a beta or RC release since 8.0 compatibility is not complete yet? 🤔 What do you think?

@glensc
Copy link
Contributor Author

glensc commented Aug 23, 2021

@falkenhawk zf1-future dudes took our incomplete pull request and claim it's complete :D

but RC or BETA sounds good, just I don't see anybody making any changes anytime soon here. and probably should even use the next version 1.14.0

in my opinion, the code works, but it will behave differently on errors. i.e some errors need to be re-thrown to be compatible with how PHP 5.3 behaved. but it's huge work and not sure if anybody has that amount of time to implement it.

it's also questionable is it reasonable to do.

these details are somewhere in some PR body, I hope you remember the dilemma when I tried to update unit tests.

@glensc
Copy link
Contributor Author

glensc commented Sep 10, 2021

@falkenhawk can you finish this, please? I think moving faster is always good. if the new release is not good enough, you can just pin it to the working version. it's not like we add new features that you want to have both.

we could get more users than me, you and Megatherium if the project looks like maintained :D

@glensc
Copy link
Contributor Author

glensc commented Sep 10, 2021

I've created a new PR with the plan of 1.14.0 release:

@glensc glensc closed this Sep 10, 2021
@falkenhawk falkenhawk mentioned this pull request Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants