Catch ValueError on PHP 8.0 for Pdo Statement #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHP Fatal error: Uncaught ValueError: PDOStatement::setFetchMode(): Argument zf1s#1 ($mode) must be a bitmask of PDO::FETCH_* constants
PHP Fatal error: Uncaught TypeError: fopen(): Argument zf1s#1 ($filename) must be of type string, XMLParser given
FPHP Fatal error: Uncaught ValueError: Path cannot be empty
Configuration read from /Users/glen/scm/php/zf1/zf1s/phpunit.xml.dist
With php 8.0, the class can't be constructed if constant is missing so the runtime check of extension can never be reached.
Merged
|
superseded by #106 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example:
Addresses previous fix with backward-compatible behavior:
For example, outer code expects
Zend_Db_Statement_Exceptionto be thrown, but instead,\ValueErroris thrown, and the whole application breaks:Note: Even old PHPUnit breaks because
\Erroris not a subclass of\Exception:)