Merge branch 'hotfix/96-empty-string'

Close #97
Fixes #96

CHANGELOG.md

@@ -2,7 +2,7 @@
 
 All notable changes to this project will be documented in this file, in reverse chronological order by release.
 
-## 1.3.2 - TBD
+## 1.3.2 - 2017-11-15
 
 ### Added
 
@@ -22,7 +22,9 @@ All notable changes to this project will be documented in this file, in reverse
 
 ### Fixed
 
-- Nothing.
+- [#97](https://github.com/zfcampus/zf-content-negotiation/pull/97) fixes an
+  issue in the `ContentTypeListener` whereby empty content was leading to an
+  uninitialized string offset notice .
 
 ## 1.3.1 - 2017-11-14
 

src/ContentTypeListener.php

@@ -102,7 +102,7 @@ public function __invoke(MvcEvent $e)
                 }
 
                 // Try to assume JSON if content starts like JSON and no explicit Content-Type was provided
-                if (! $bodyParams && in_array($content[0], ['{', '['], true)) {
+                if (! $bodyParams && strlen($content) > 0 && in_array($content[0], ['{', '['], true)) {
                     $bodyParams = $this->decodeJson($content);
                 }
 

test/ContentTypeListenerTest.php

@@ -647,4 +647,64 @@ public function testStringContentIsParsedCorrectlyToAnArray($method, $data, $key
         $this->assertArrayHasKey($key, $array);
         $this->assertSame('', $array[$key]);
     }
+
+    public function nonPostMethodsContent()
+    {
+        $dataSets = [
+            'object' => [
+                'data' => '{"key": "value"}',
+                'expected' => ['key' => 'value'],
+            ],
+            'array' => [
+                'data' => '["first", "second"]',
+                'expected' => ['first', 'second'],
+            ],
+            /** @see https://github.com/zfcampus/zf-content-negotiation/pull/96 */
+            'empty' => [
+                'data' => '',
+                'expected' => [],
+            ],
+        ];
+
+        foreach (['PUT', 'PATCH', 'DELETE'] as $method) {
+            foreach ($dataSets as $type => $set) {
+                $name = sprintf('%s-%s', $type, $method);
+                yield $name => [$method, $set['data'], $set['expected']];
+            }
+        }
+    }
+
+    /**
+     * @dataProvider nonPostMethodsContent
+     *
+     * @see https://github.com/zfcampus/zf-content-negotiation/pull/94
+     * @see https://github.com/zfcampus/zf-content-negotiation/pull/96
+     * @param string $method HTTP method
+     * @param string $data HTTP body content
+     * @param mixed $expected Expected body params
+     */
+    public function testMissingContentTypeHeaderResultsInParsingAsJsonIfInitialCharacterIndicatesObjectOrArray(
+        $method,
+        $data,
+        $expected
+    ) {
+        $listener = $this->listener;
+
+        $request = new Request();
+        $request->setMethod($method);
+        $request->setContent($data);
+
+        $event = new MvcEvent();
+        $event->setRequest($request);
+        $event->setRouteMatch($this->createRouteMatch([]));
+
+        $result = $listener($event);
+        $this->assertNull($result);
+
+        /** @var \ZF\ContentNegotiation\ParameterDataContainer $params */
+        $params = $event->getParam('ZFContentNegotiationParameterData');
+        $test = $params->getBodyParams();
+
+        $this->assertSame($expected, $test);
+    }
 }