This repository has been archived by the owner on Jan 21, 2020. It is now read-only.
Fixes uninitialized string offset error #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As reported in zfcampus#96, since zfcampus#94 and the 1.3.1 release, if the body content for a PUT, PATCH, or DELETE call is empty, an "Uninitialized string offset: 0" notice is raised. This patch adds tests missing from the original patch created for zfcampus#94, verifying that JSON deserialization occurs for those HTTP methods if the content looks like JSON but no Content-Type header was present. The new cases also include scenarios where no content is present. A fix is introduced to the `ContentTypeListener` to ensure the notice is no longer raised.
weierophinney
force-pushed
the
hotfix/96-empty-string
branch
from
6ff82dd
to
649b679
Compare
weierophinney
added a commit
that referenced
this pull request
Nov 15, 2017
weierophinney
added a commit
that referenced
this pull request
Nov 15, 2017
Forward port #97 Conflicts: CHANGELOG.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #96, since #94 and the 1.3.1 release, if the body content for a PUT, PATCH, or DELETE call is empty, an "Uninitialized string offset: 0" notice is raised.
This patch does the following: