Use link extractors #103
Use link extractors #103
Conversation
|
I like this idea. It will also allow people to add their own |
|
@neeckeloo I ❤️ this! Looks like you may need a few more tests? Also, some docs in the README about the new classes and where they fit in would be useful for those that want to use the features in a more advanced fashion. |
|
I currently use inheritance to manage the relationship between |
|
IMHO while inheritance is definitely works, aggregation would have the added benefit that if there are other types of |
|
|
||
| `LinkExtractor` is responsible for extracting a link representation from `Link` instance. | ||
|
|
||
| #### ZF\Hal\Extractor\LinkExtractorCollection |
There was a problem hiding this comment.
s/LinkExtractorCollection/LinkCollectionExtractor/ (I'll do that during merge; just noting it so I don't forget.)
- Removed dependency on `Zend\Stdlib\Extractor\ExtractionInterface`,
and:
- Added `extract(Link $link)` to `LinkExtractorInterface`.
- Added `extract(LinkCollection $collection)` to `LinkCollectionExtractorInterface`.
In each case, this allowed removing the initial conditional that
checked for a valid type (as the check is happening prior to invoking
the method regardless!), and removing an obsolete test for this edge
case.
- Removed `setLinkExtractor()` from `LinkCollectionExtractorInterface`,
as it's unused in the given API, and should be an implementation
detail. It was *not* removed from the implementation.
- Changed `{@inheritdoc}` annotations to `@inheritDoc`.
- Updated copyright to 2015.
|
Merged to develop for release on the 1.2.0 tag. |
The goal is to start reducing the scope of the plugin by adding some classes with well defined role.