-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Binned implementation #272
Conversation
Hello, I've been looking around for a good Python fit package that can also do binned fits. I'm curious what the status is of this branch? Thanks! |
Hi, thanks for asking and yes, this is in progress. It ain't finished yet (and we're just releasing the new minimizers) but will work on it then again fully. So this is surely going to come, it's an essential part of the library. (btw: it's actually quite easy to just create your own binned loss with zfit, a few colleagues have done that if you would really need it) |
Thanks, looking forward to it. Implementing it myself is not hard (I've done it before), but I prefer to use a good implementation. I guess I'll use my hack for now :) |
# Conflicts: # .pre-commit-config.yaml # tests/test_loss.py # zfit/core/loss.py # zfit/core/parameter.py # zfit/minimizers/minimizer_minuit.py
8373f82
to
1152bb4
Compare
# Conflicts: # CHANGELOG.rst # zfit/models/basic.py
Merging this for an alpha pre-release. It's not finalised but the design should be accessible to testers. |
Implements the basic structure needed for binned fits and leverages the zfit models to a new level.
Closes zfit/zfit-development#10, zfit/zfit-development#31, zfit/zfit-development#28
Proposed Changes
norm_range
keyword tonorm
Tests added
Checklist