Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binned implementation #272

Merged
merged 114 commits into from
Dec 1, 2021
Merged

Binned implementation #272

merged 114 commits into from
Dec 1, 2021

Conversation

jonas-eschle
Copy link
Contributor

@jonas-eschle jonas-eschle commented Oct 12, 2020

Implements the basic structure needed for binned fits and leverages the zfit models to a new level.

Closes zfit/zfit-development#10, zfit/zfit-development#31, zfit/zfit-development#28

Proposed Changes

  • change norm_range keyword to norm

Tests added

Checklist

  • change approved
  • implementation finished
  • correct namespace imported
  • tests added
  • CHANGELOG updated

@mbaak
Copy link

mbaak commented Feb 24, 2021

Hello, I've been looking around for a good Python fit package that can also do binned fits. I'm curious what the status is of this branch? Thanks!

@jonas-eschle
Copy link
Contributor Author

Hi, thanks for asking and yes, this is in progress. It ain't finished yet (and we're just releasing the new minimizers) but will work on it then again fully.

So this is surely going to come, it's an essential part of the library.

(btw: it's actually quite easy to just create your own binned loss with zfit, a few colleagues have done that if you would really need it)

@mbaak
Copy link

mbaak commented Feb 25, 2021

Thanks, looking forward to it. Implementing it myself is not hard (I've done it before), but I prefer to use a good implementation. I guess I'll use my hack for now :)

@jonas-eschle jonas-eschle changed the title WIP Binned implementation Binned implementation Nov 30, 2021
@jonas-eschle
Copy link
Contributor Author

Merging this for an alpha pre-release. It's not finalised but the design should be accessible to testers.
Tests are up, missing are simply features to make it complete and docs, changelog tutorials.

@jonas-eschle jonas-eschle merged commit 11d066a into develop Dec 1, 2021
@jonas-eschle jonas-eschle deleted the binned_new branch December 1, 2021 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Software specs - limitations
2 participants