Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in gc.rs causing a sqlx panic that completely crashes atticd #115

Closed
ixmatus opened this issue Feb 28, 2024 · 0 comments
Closed

Bug in gc.rs causing a sqlx panic that completely crashes atticd #115

ixmatus opened this issue Feb 28, 2024 · 0 comments

Comments

@ixmatus
Copy link
Contributor

ixmatus commented Feb 28, 2024

Specifically, we're getting this panic from atticd:

thread 'main' panicked at 'assertion failed: self.param_types.len() <= (u16::MAX as usize)'

... which is related to this sqlx issue: launchbadge/sqlx#671 (comment) but only because the number of chunks to garbage collect have grown beyond psql's purported bind parameter limit.

We narrowed the issue down (via the stack trace) to this query:

.and_where(chunk::Column::Id.in_subquery(orphan_chunk_ids))

This problem takes down atticd entirely. We will submit a PR to fix this but I wanted to open this ticket for tracking purposes.

zhaofengli added a commit that referenced this issue Jun 1, 2024
gc.rs: `LIMIT` number of `orphan_chunks`, fixes #115
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant