[Fix] splitFile.py - attrib command fails on Linux/OSX #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
only set attrib on non unix machines
set archive attrib only on windows os
using mattrib as alternative for attrib in windows installation of mtools is required, so the script checks if the command is available prior execution
|
|
Will this be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The splitFile.py script fails on Linux and OSX without this modification as the 'attrib' command is not available on those systems ( probably includes java environments, but I only checked ubuntu and osx)
This fix prevents this function to be executed if the environment is a non-windows one