Skip to content

Commit

Permalink
widgets: Add support for clickable links.
Browse files Browse the repository at this point in the history
The change was made to support links in polls, as mentioned in
issue zulip#12947. We used markdown renderer to render
the link content, and parsed out any unnecessary p tags.
We changed javascript and hbs files so that they properly
render the content. Tested locally whether the links work,
in addition to checking for XSS vulnerbilities.
Everything tested worked, and no vulnerabilities
discovered. Double check that there are no XSS
issues.

Fixes: #1294o7
  • Loading branch information
zhark01 committed Dec 6, 2020
1 parent 07e27b7 commit 9e70f2f
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion zerver/lib/actions.py
Original file line number Diff line number Diff line change
Expand Up @@ -1819,7 +1819,6 @@ def do_add_submessage(realm: Realm,
content=content,
)
submessage.save()
print("here")
event = dict(
type="submessage",
msg_type=msg_type,
Expand Down

0 comments on commit 9e70f2f

Please sign in to comment.