Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:lottie动画js库较大,采用apng实现 #63

Merged
merged 2 commits into from
Jan 11, 2021

Conversation

jkfzero
Copy link
Collaborator

@jkfzero jkfzero commented Jan 7, 2021

lottie动画js库较大,采用apng实现动画,apng兼容性良好
https://caniuse.com/?search=apng
svga默认不支持after effects的描边,本动画使用到了,修改成本较大,暂不考虑svga方案
http://svga.io/article.html

@zhhyang
Copy link
Owner

zhhyang commented Jan 7, 2021

  1. 图片的地址最好改成 // 的方式
  2. 组件是否可以改成FC
  3. 删除 loading.json文件
  4. 是否可以扩展一下使用方式,提供静态 Loading.show() Loading.hide() 简化使用方式,开发者不用再自己维护状态来控制显示和隐藏,可参考Toast组件的使用

@jkfzero
Copy link
Collaborator Author

jkfzero commented Jan 11, 2021

1,2,3处理了,4我觉得没必要加feature了,如果要加做个单独的feature后续支持,现在我看到的调用里没有需要这个状态的。

@zhhyang zhhyang merged commit 86fd737 into zhhyang:master Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants