-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
session: allow to borrow the stream mutably #36
Conversation
Hi @tzemanovic Overall I doubt if it's good design to expose As I see your use case, you need You could just call
You mean it blocks because it is slower or because there some output wasn't processed which is unexpected?
See my comment in #35 also related. |
ping @tzemanovic |
@zhiburt thanks again, I'll try to switch to
I'm not quite sure tbh - in the test case we run e.g. a server in expectrl session and another session with a client, which submits something to the server and we expect it to print something after response from the node. However, the server session is not processing its output (there's no active |
forgot to note - we're using the sync version |
|
Could I run this flow myself? |
Sure, but I have to admit that the project is quite heavy to compile, so it is by no means a minimal example. From the branch of https://github.com/anoma/anoma/pull/1095, you can If we remove |
related to #35 - we'd like to be able to get access to the session's stream - we're using it to put a process to a background with https://github.com/anoma/anoma/blob/c17f4f634b14ee2f202ec51c3f9d4eb1a7f996a1/tests/src/e2e/setup.rs#L468 - we found unlike in rexpect, when we run multiple sessions at once and the commands that they run interact with each other in some way, if some session's output is not being processed it gets blocked on it