Add CheckStyle #42
Add CheckStyle #42
Conversation
| * @param uri Uri of the loaded image | ||
| */ | ||
| void loadThumbnail(Context context, int resize, Drawable placeholder, ImageView imageView, Uri uri); | ||
| void loadThumbnail(Context context, int resize, Drawable placeholder, ImageView iv, Uri uri); |
There was a problem hiding this comment.
Is this renaming your own favor or checkstyle's constraint
There was a problem hiding this comment.
My own favor.
First I set max length 100 and I modified some file ,however later I found Matisse has many lines over 100 while it's very hard to cut down these line's length.So I set max length 120 thus as you see some changes are bad.
There was a problem hiding this comment.
Well, such naming style can lead to sort of confusion, and we can wrap the line to avoid reaching the column limit.
| * @param imageView ImageView widget | ||
| * @param uri Uri of the loaded image | ||
| */ | ||
| void loadImage(Context context, int resizeX, int resizeY, ImageView imageView, Uri uri); | ||
| void loadImage(Context context, int rX, int rY, ImageView imageView, Uri uri); |
There was a problem hiding this comment.
I think rX and rY‘s readability is not good.
| } | ||
|
|
||
| @Override | ||
| public RecyclerView.ViewHolder onCreateViewHolder(ViewGroup parent, int viewType) { | ||
| if (viewType == VIEW_TYPE_CAPTURE) { | ||
| View v = LayoutInflater.from(parent.getContext()).inflate(R.layout.photo_capture_item, parent, false); | ||
| View v = LayoutInflater.from(parent.getContext()). | ||
| inflate(R.layout.photo_capture_item, parent, false); |
There was a problem hiding this comment.
Seems that if you set your IDE's max line length to be 120, this line should not wrap. The same below.
| @@ -30,7 +30,7 @@ | |||
|
|
|||
| public class AlbumsSpinner { | |||
|
|
|||
| private static final int sMaxShownCount = 6; | |||
| private static final int S_MAX_SHOWN_COUNT = 6; | |||
There was a problem hiding this comment.
This constant should be named MAX_SHOWN_COUNT
| int baseX = (int) (canvas.getWidth() - mTextPaint.measureText(text)) / 2; | ||
| int baseY = | ||
| (int) (canvas.getHeight() - mTextPaint.descent() - mTextPaint.ascent()) / 2; | ||
| canvas.drawText(text, baseX, baseY, mTextPaint); |
There was a problem hiding this comment.
wrong wrap under 120 max line length.
| ArrayList<Item> selected = resultBundle.getParcelableArrayList(SelectedItemCollection.STATE_SELECTION); | ||
| int collectionType = resultBundle.getInt(SelectedItemCollection.STATE_COLLECTION_TYPE, SelectedItemCollection.COLLECTION_UNDEFINED); | ||
| ArrayList<Item> selected = | ||
| resultBundle.getParcelableArrayList(SelectedItemCollection.STATE_SELECTION); |
| @@ -206,7 +208,8 @@ private void updateBottomToolbar() { | |||
| public void onClick(View v) { | |||
| if (v.getId() == R.id.button_preview) { | |||
| Intent intent = new Intent(this, SelectedPreviewActivity.class); | |||
| intent.putExtra(BasePreviewActivity.EXTRA_DEFAULT_BUNDLE, mSelectedCollection.getDataWithBundle()); | |||
| intent.putExtra(BasePreviewActivity.EXTRA_DEFAULT_BUNDLE, | |||
| mSelectedCollection.getDataWithBundle()); | |||
| @@ -285,7 +288,8 @@ public void onMediaClick(Album album, Item item, int adapterPosition) { | |||
| Intent intent = new Intent(this, AlbumPreviewActivity.class); | |||
| intent.putExtra(AlbumPreviewActivity.EXTRA_ALBUM, album); | |||
| intent.putExtra(AlbumPreviewActivity.EXTRA_ITEM, item); | |||
| intent.putExtra(BasePreviewActivity.EXTRA_DEFAULT_BUNDLE, mSelectedCollection.getDataWithBundle()); | |||
| intent.putExtra(BasePreviewActivity.EXTRA_DEFAULT_BUNDLE, | |||
| mSelectedCollection.getDataWithBundle()); | |||
|
In addition I have put |
|
@CoXier It is my fault that didn't mention max line length in the project. |
No description provided.