Keep SessionLoadPost autocmd intact

[Konfekt]

Other plugins, such as FastFold, rely on the triggering of the SessionLoadPost autocmd after loadview. Therefore this pull request proposes to

• keep it by default,
• if things are slow, there's a FAQ entry and an option that disables it, and
• even if users disable it, FastFold keeps functioning.

(Without the SessionLoadPost autocmd, FastFold does not switch to manual folding which makes editing large files with syntax or expr folding slow.)

[kopischke]

Thanks for the PR, but stay already fires the SessionLoadPost event every time a view session is loaded; it just does so in a somewhat more targeted way than the sweeping :doautoall of standard view session files. This has been so since version 1.2.0.

If that event did not fire for you, you might have stumbled on a bug in the plugin logic. In that case, I would ask you to help me track that exact bug by providing me with a way to reproduce it – introducing a user setting to compromise between integration or a performance penalty would be my very last resort.

[Konfekt]

Well, this is with

VIM - Vi IMproved 7.4 (2013 Aug 10)
Included patches: 1-1467
Compiled by 'http://www.opensuse.org/'

and I did not notice it with older versions. Maybe you can reproduce it with the latest Vim and FastFold as well?

[Konfekt]

Perhaps exists('#'.join(l:event, '#')) at https://github.com/kopischke/vim-stay/blob/v1.3.1/autoload/stay/view.vim#L101 is now case sensitive or something?

[Konfekt]

See,

echo exists('#SessionLoadPost#')

here gives 0.

[Konfekt]

Ok, also

b:stay_loaded_view

is not defined.

[kopischke]

Yes of course it does, the syntax is wrong in your test. Could you report what

:echo exists('#SessionLoadPost')

returns on your system? That is what is actually tested in the line you linked to: the second # is part of a join() when a pattern is present additionally to the event name.

[kopischke]

OK, b:stay_loaded_view being undefined sounds like the root cause of the problem. Could you tell me what your &viewdir is set to? And &eventignore, while you are at it?

[Konfekt]

Viewdir is ~/.cache/vim/view and eventignore empty

[Konfekt]

Well it is ... /view// and the stridx function returns -1. Adapting the if clause to check for - 1 solves everything.

[kopischke]

Adapting the if clause to check for - 1 solves everything.

Not really, as it subverts the check for “file is sourced from viewdir”, but it does pinpoint the issue: me checking far too naively for that exact condition. I’ll see that I get this fixed.

[kopischke]

@Konfekt FYI I am tracking this in #26.