Merge pull request adobe#2834 from adobe/glenn/help-divider

Remove extra divider from help menu
zhizhangchen · Feb 9, 2013 · 722f7ec · 722f7ec
2 parents 8910874 + a202845
commit 722f7ec
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/src/command/Menus.js b/src/command/Menus.js
@@ -1113,12 +1113,18 @@ define(function (require, exports, module) {
         menu.addMenuItem(Commands.HELP_SHOW_EXT_FOLDER);
 
 
-        menu.addMenuDivider();
+        var hasAboutItem = (brackets.platform !== "mac" || brackets.inBrowser);
+
+        // Add final divider only if we have a twitter URL or about item
+        if (hasAboutItem || brackets.config.twitter_url) {
+            menu.addMenuDivider();
+        }
+
         if (brackets.config.twitter_url) {
             menu.addMenuItem(Commands.HELP_TWITTER);
         }
         // supress redundant about menu item in mac shell
-        if (brackets.platform !== "mac" || brackets.inBrowser) {
+        if (hasAboutItem) {
             menu.addMenuItem(Commands.HELP_ABOUT);
         }