Simplify crypto attachment support and improve error handling

Details:

- Simplified and addressed complexity of code in ensure_attached()
  by renaming variables, moving code around so that code that
  logically belongs together is also located together.

- Simplified the example playbooks for crypto attachment, by
  having them deal with a single target partition.

- Improved error handling by wrappering zhmcclient exceptions
  so the message shows a better context of what was attempted.

Signed-off-by: Andreas Maier <maiera@de.ibm.com>

playbooks/attach_crypto_2.yml → playbooks/attach_crypto.yml

@@ -6,16 +6,16 @@
     - vault.yml
   tasks:
 
-  - name: Ensure domains 1-max on 1 adapter are attached in usage mode to partition 2
+  - name: "Ensure domains 2-max on 4 adapters are attached in usage mode to partition {{ partition_name }}"
     zhmc_crypto_attachment:
       hmc_host: "{{ hmc_host }}"
       hmc_auth: "{{ hmc_auth }}"
       cpc_name: "{{ cpc_name }}"
-      partition_name: "{{ partition2_name }}"
+      partition_name: "{{ partition_name }}"
       state: attached
       crypto_type: ep11
-      adapter_count: 1
-      domain_range: 1,-1
+      adapter_count: 4
+      domain_range: 2,-1
       access_mode: usage
       log_file: crypto.log
     register: result

playbooks/detach_crypto.yml

@@ -6,7 +6,7 @@
     - vault.yml
   tasks:
 
-  - name: Ensure partition 1 has all crypto adapters and domains detached
+  - name: "Ensure partition {{ partition_name }} has all crypto adapters and domains detached"
     zhmc_crypto_attachment:
       hmc_host: "{{ hmc_host }}"
       hmc_auth: "{{ hmc_auth }}"
@@ -19,31 +19,3 @@
   - name: Print the result
     debug:
       var: result
-
-  - name: Ensure partition 2 has all crypto adapters and domains detached
-    zhmc_crypto_attachment:
-      hmc_host: "{{ hmc_host }}"
-      hmc_auth: "{{ hmc_auth }}"
-      cpc_name: "{{ cpc_name }}"
-      partition_name: "{{ partition2_name }}"
-      state: detached
-      log_file: crypto.log
-    register: result
-
-  - name: Print the result
-    debug:
-      var: result
-
-  - name: Ensure partition 3 has all crypto adapters and domains detached
-    zhmc_crypto_attachment:
-      hmc_host: "{{ hmc_host }}"
-      hmc_auth: "{{ hmc_auth }}"
-      cpc_name: "{{ cpc_name }}"
-      partition_name: "{{ partition3_name }}"
-      state: detached
-      log_file: crypto.log
-    register: result
-
-  - name: Print the result
-    debug:
-      var: result

playbooks/facts_crypto.yml

@@ -6,7 +6,7 @@
     - vault.yml
   tasks:
 
-  - name: Get facts about crypto config of partition 1
+  - name: "Get facts about crypto config of partition {{ partition_name }}"
     zhmc_crypto_attachment:
       hmc_host: "{{ hmc_host }}"
       hmc_auth: "{{ hmc_auth }}"
@@ -19,31 +19,3 @@
   - name: Print the result
     debug:
       var: result
-
-  - name: Get facts about crypto config of partition 2
-    zhmc_crypto_attachment:
-      hmc_host: "{{ hmc_host }}"
-      hmc_auth: "{{ hmc_auth }}"
-      cpc_name: "{{ cpc_name }}"
-      partition_name: "{{ partition2_name }}"
-      state: facts
-      log_file: crypto.log
-    register: result
-
-  - name: Print the result
-    debug:
-      var: result
-
-  - name: Get facts about crypto config of partition 3
-    zhmc_crypto_attachment:
-      hmc_host: "{{ hmc_host }}"
-      hmc_auth: "{{ hmc_auth }}"
-      cpc_name: "{{ cpc_name }}"
-      partition_name: "{{ partition3_name }}"
-      state: facts
-      log_file: crypto.log
-    register: result
-
-  - name: Print the result
-    debug:
-      var: result