Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't Resolve Module - lamejs is broken for npm usage #40

Closed
djalmaaraujo opened this issue May 15, 2017 · 11 comments
Closed

Can't Resolve Module - lamejs is broken for npm usage #40

djalmaaraujo opened this issue May 15, 2017 · 11 comments

Comments

@djalmaaraujo
Copy link

djalmaaraujo commented May 15, 2017

ERROR in ./~/use-strict/index.js
Module not found: Error: Can't resolve 'module' in '/Users/cooper/dev/closeio/closeio/closeio/static/node_modules/use-strict'
 @ ./~/use-strict/index.js 1:13-30
 @ ./~/lamejs/src/js/lametest.js
 @ ./js/voicemail-recorder/encoder.js
 @ ./js/voicemail-recorder/mic-recorder.js
 @ ./js/views/settings/voicemail_recorder.js
 @ ./js/test/tests/settings/voicemail_recorder.js
 @ ./js/test/tests.js

If you comment the first line on lametest.js, everythin works as expected:

// require('use-strict');

@zhuker
I am using the npm-package lamejs. I am not sure the reason you are using this module "use-strict", but it fixes when you comment this line. If you think this module is not useful anymore, I can remove and open a PR.

djalmaaraujo added a commit to closeio/lamejs that referenced this issue May 15, 2017
@Jandou6
Copy link

Jandou6 commented May 22, 2017

I have the same problem, Cannot resolve module 'module'......??

@deanslamajr
Copy link
Contributor

c4638f8 closes this issue also

@zhuker @geeee will c4638f8 be deployed to npm?

@deanslamajr
Copy link
Contributor

@djalmaaraujo @Jandou6
due to this repo's owners not deploying the latest branch to npm, I've forked and deployed a working version => https://www.npmjs.com/package/iso-lamejs

@buzinas
Copy link

buzinas commented Jun 24, 2017

@geeee @zhuker can you please publish master on npm under ^1.2.0?

@zhuker
Copy link
Owner

zhuker commented Jun 24, 2017

@buzinas published let me know if it works

@zhuker
Copy link
Owner

zhuker commented Jun 24, 2017

published 1.2.0 to npm

@zhuker zhuker closed this as completed Jun 24, 2017
@djalmaaraujo
Copy link
Author

@deanslamajr check it out.l

@buzinas
Copy link

buzinas commented Jun 24, 2017

Thanks @zhuker, I'll test it.

@djalmaaraujo
Copy link
Author

Thanks @zhuker

@deanslamajr
Copy link
Contributor

@djalmaaraujo yep, this works!!
Thanks @zhuker

@djalmaaraujo
Copy link
Author

Thanks @zhuker, this is why we wanted to use your library: https://github.com/closeio/mic-recorder-to-mp3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants