-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addtional Plotting/DataAnalysis Tools in OpenSeesPy #33
Comments
These functions look good. You are most welcome to create a pull request to add to the plotting functions or make the existing functions more efficient. There is PR #32 to reduce code repetition within the functions. I am working on documentation explaining what is going on inside the Get_Rendering library so others can easily modify it. Also, how do you handle plotting mode shapes in OpenSeesPyTools? I couldn't see it in the functions. |
Thank you for contributing the codes. Just as @u-anurag said, you are very welcome to send PR with the source, documentation and examples. If two of you can have a conversations about how to merge your tools in the existing functions, it would be perfect. For now, there isn't any tests setup for plotting functions. We may have to do it in the future. Thank you so much. I can't wait to see these plots. |
@u-anurag @zhuminjie / @u-anurag @zhuminjie |
@cslotboom You can continue the public discussion on #17. Also, I have documented and tried to explain the working of Get_Rendering library in PR zhuminjie/OpenSeesPyDoc#190. Please go through the code and see if you can add the animation function in it. Feel free to ask questions/discuss in #17. |
@u-anurag Thank you for initiating the discussion. @cslotboom There are already tests in this folder https://github.com/zhuminjie/OpenSeesPy/tree/master/openseespy-pip/openseespy/test If you want, you add a new test file with name test_filename.py in that folder. |
@zhuminjie - I'm wondering if you know of a way that section geometric information can be returned via a command. |
I saw you have posted on the OpenSeesPy Forum. I am going to close this one. |
I was a little nervous to create a pull request, but I've recently published some tools that can be used to animate and plot OpenSeesPy models, as well as do some data analysis:
https://github.com/cslotboom/OpenSeesPyTools
For my model plotting functions, I've used the original plot function from @u-anurag as a base.
I'd be happy to contribute any of this code to base package, or collaborate with people using them. However, I'm not sure how receptive people are to changes in the existing plot functions. I'm also not sure what the appetite is for non plotting functions. Either way, I just thought I would get the ball rolling.
Some notable comments:
The text was updated successfully, but these errors were encountered: