Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logo adjustments and new versions #6

Merged
merged 11 commits into from
May 2, 2020
Merged

Conversation

KeyboardRage
Copy link
Contributor

Reference to issue #5

I've made the optimizations I could find on the logos. Feel free to do a double-check in case I missed something.

The logo on one of the illustrations was also changed to have new version of logo.

I've also added versions of the logos, and a short description on when to use which logo versions.

Color changed from initial version I proposed, where the orange was a bit off from what you currently use—this has been adjusted to be the same as the color you are currently using, so it is consistent with existing theme.

@Aransentin
Copy link
Sponsor Contributor

The previous logo was draw using a combination of shape-rendering="crispEdges" shapes for the blocky parts, overlaid by non-crispEdges shapes for the diagonals. The new logo (while being an aesthetic improvement) doesn't have that and will look blurry when scaled – and since the viewbox of the SVG is the rather odd 279×254.6 that will pretty much always happen in practice.

@KeyboardRage
Copy link
Contributor Author

The previous logo was draw using a combination of shape-rendering="crispEdges" shapes for the blocky parts, overlaid by non-crispEdges shapes for the diagonals. The new logo (while being an aesthetic improvement) doesn't have that and will look blurry when scaled – and since the viewbox of the SVG is the rather odd 279×254.6 that will pretty much always happen in practice.

I don't have any experience with those kinds of combining methods for SVG, but I see it now. Thank you for pointing that out. I will make appropriate changes and adopt these techniques. Should be updated in about an hour or two 👍

@KeyboardRage
Copy link
Contributor Author

Update: Believe I'm getting close to finish now, doing it the correct way. Feel free to verify.

I just need to make final adjustments to the highlighted part that I missed, as they could create a small section of "blur", then make another push.

Copy link
Member

@andrewrk andrewrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the difference between zig-logo.svg and zig_color_dark.svg?
What's the difference between zig-icon.svg and zig_symbol_color.svg?

Can you canonicalize the data and make the naming consistent?

README.md Outdated
Comment on lines 26 to 27
* `full logo/zig_dark.svg` where color reproduction is not possible, or visibility of colored symbol is too low.
* `full logo/zig_white.svg` where color reproduction is not possible, or visibility of `zig_dark.svg` is too low.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pardon this possibly ignorant question- is there any reason to have these versions in this repository of canonical forms, since they can be trivially generated from either of the color versions by changing the color to black/white?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To answer your first question, they are 100% identical. I will have to rename the index logo to make it consistent and logical with the colour versions.

To cater for differences in versions, the naming could be something like
zig_logo_black.svg for colour symbol, black text.
zig_logo_white.svg for colour symbol, white text.
zig_logo_black.nev.svg for black symbol, black text.
zig_logo_white.nev.svg for white symbol, white text.
zig_symbol_color.svg for colour symbol.
zig_symbol_white.nev.svg for white symbol.
zig_symbol_black.nev.svg for black symbol.

Second question, there's two reasons you'd have these versions.

  1. If for print, white/light version is sometimes adjusted slightly to be "thicker" some places to make up for ink flow tightening margins, much like smaller sizes on screen. This reason is not applicable here for web.

  2. Second reason is to have easily accessible versions for people that do not have access to nor knowledge of working with SVG's. If you feel like this is not a concern, you can remove the folders containing copies in various colour combinations.

Copy link
Member

@andrewrk andrewrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much! I'm ready to merge this. Is it ready?

Comment on lines +26 to +29
* `full logo/zig_color_black.svg` is the main logo, preferably used on applicable backgrounds.
* `full logo/zig_color_white.svg` when visibility of the main logotype ("ZIG") is too low.
* `full logo/zig_black.neg.svg` where color reproduction is not possible, or visibility of colored symbol is too low.
* `full logo/zig_white.neg.svg` where color reproduction is not possible, or visibility of `zig_dark.neg.svg` is too low.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the "full logo" part can be removed now, yeah?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean the part of the reference in the README.md? Yeah, doesn't matter much as the naming is clear like it is now.

Aside from that, yes, it is ready :)

@andrewrk andrewrk merged commit a723be7 into ziglang:master May 2, 2020
@andrewrk
Copy link
Member

andrewrk commented May 2, 2020

Done! Thanks again. It looks great!

@andrewrk
Copy link
Member

andrewrk commented May 2, 2020

@KeyboardRage is there a missing crisp edge on the top bottom of the Z?

berlioz

@KeyboardRage
Copy link
Contributor Author

@KeyboardRage is there a missing crisp edge on the top bottom of the Z?

berlioz

Shouldn't be. Changed that along with top of the "opening bracket" yesterday—but that doesn't change the fact that it looks like it, and most likely is. 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants