Merge pull request #644 from Dubhead/Dubhead-fix-message-color

Fix the color of compiler messages for light-themed terminal.
ziglang · Dec 4, 2017 · 67e6d9b · 67e6d9b
2 parents 76f3bdf + fea016a
commit 67e6d9b
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 4 deletions.
diff --git a/src/errmsg.cpp b/src/errmsg.cpp
@@ -24,20 +24,20 @@ static void print_err_msg_type(ErrorMsg *err, ErrColor color, ErrType err_type)
     bool is_tty = os_stderr_tty();
     if (color == ErrColorOn || (color == ErrColorAuto && is_tty)) {
         if (err_type == ErrTypeError) {
-            os_stderr_set_color(TermColorWhite);
+            os_stderr_set_color(TermColorBold);
             fprintf(stderr, "%s:%" ZIG_PRI_usize ":%" ZIG_PRI_usize ": ", path, line, col);
             os_stderr_set_color(TermColorRed);
             fprintf(stderr, "error:");
-            os_stderr_set_color(TermColorWhite);
+            os_stderr_set_color(TermColorBold);
             fprintf(stderr, " %s", text);
             os_stderr_set_color(TermColorReset);
             fprintf(stderr, "\n");
         } else if (err_type == ErrTypeNote) {
-            os_stderr_set_color(TermColorWhite);
+            os_stderr_set_color(TermColorBold);
             fprintf(stderr, "%s:%" ZIG_PRI_usize ":%" ZIG_PRI_usize ": ", path, line, col);
             os_stderr_set_color(TermColorCyan);
             fprintf(stderr, "note:");
-            os_stderr_set_color(TermColorWhite);
+            os_stderr_set_color(TermColorBold);
             fprintf(stderr, " %s", text);
             os_stderr_set_color(TermColorReset);
             fprintf(stderr, "\n");

diff --git a/src/os.cpp b/src/os.cpp
@@ -931,6 +931,7 @@ int os_self_exe_path(Buf *out_path) {
 #define VT_GREEN "\x1b[32;1m"
 #define VT_CYAN "\x1b[36;1m"
 #define VT_WHITE "\x1b[37;1m"
+#define VT_BOLD "\x1b[0;1m"
 #define VT_RESET "\x1b[0m"
 
 static void set_color_posix(TermColor color) {
@@ -947,6 +948,9 @@ static void set_color_posix(TermColor color) {
         case TermColorWhite:
             fprintf(stderr, VT_WHITE);
             break;
+        case TermColorBold:
+            fprintf(stderr, VT_BOLD);
+            break;
         case TermColorReset:
             fprintf(stderr, VT_RESET);
             break;
@@ -989,6 +993,7 @@ void os_stderr_set_color(TermColor color) {
             SetConsoleTextAttribute(stderr_handle, FOREGROUND_GREEN|FOREGROUND_BLUE|FOREGROUND_INTENSITY);
             break;
         case TermColorWhite:
+        case TermColorBold:
             SetConsoleTextAttribute(stderr_handle,
                 FOREGROUND_RED|FOREGROUND_GREEN|FOREGROUND_BLUE|FOREGROUND_INTENSITY);
             break;

diff --git a/src/os.hpp b/src/os.hpp
@@ -21,6 +21,7 @@ enum TermColor {
     TermColorGreen,
     TermColorCyan,
     TermColorWhite,
+    TermColorBold,
     TermColorReset,
 };