Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zig test --verbose-air crashes even on an empty file #10031

Closed
jmc-88 opened this issue Oct 25, 2021 · 0 comments · Fixed by #10033
Closed

zig test --verbose-air crashes even on an empty file #10031

jmc-88 opened this issue Oct 25, 2021 · 0 comments · Fixed by #10033
Labels
bug Observed behavior contradicts documented or intended behavior stage1 The process of building from source via WebAssembly and the C backend.
Milestone
0.9.0

Comments

@jmc-88
Copy link
Sponsor Contributor

jmc-88 commented Oct 25, 2021 •
edited by andrewrk

Zig Version

0.9.0-dev.1459+069c83d58

Steps to Reproduce

$ touch empty.zig
$ zig test --verbose-air empty.zig

Expected Behavior

No crash.

Actual Behavior

Crash in render_const_val_array(). From the output, it seems to occur when processing lib/zig/std/special/test_runner.zig:10:57, which if I'm reading things correctly is args_buffer in:

zig/lib/std/special/test_runner.zig

Line 10 in ed73281

var args_allocator = std.heap.FixedBufferAllocator.init(&args_buffer);

Uploading the part of the output that seems relevant to test_runner.zig -- not uploading the entire thing because it's >70 MiB.

log.txt
@jmc-88 jmc-88 added the bug Observed behavior contradicts documented or intended behavior label Oct 25, 2021
@jmc-88 jmc-88 changed the title zig test --verbose-air crashes zig test --verbose-air crashes even on an empty file Oct 25, 2021
jmc-88 added a commit to jmc-88/zig that referenced this issue Oct 25, 2021
@jmc-88
Don't call render_const_val_array() on undefined.
133bb3f 
Fixes ziglang#10031.
jmc-88 added a commit to jmc-88/zig that referenced this issue Oct 25, 2021
@jmc-88
Don't call render_const_val_array() on undefined.
9042926 
Fixes ziglang#10031.
@jmc-88 jmc-88 mentioned this issue Oct 25, 2021
Merged
jmc-88 added a commit to jmc-88/zig that referenced this issue Oct 25, 2021
@jmc-88
Don't call render_const_val_array() on undefined
7bcec0e 
Fixes ziglang#10031.
andrewrk pushed a commit that referenced this issue Oct 26, 2021
@jmc-88 @andrewrk
Don't call render_const_val_array() on undefined
17e46a3 
Fixes #10031.
@andrewrk andrewrk added the stage1 The process of building from source via WebAssembly and the C backend. label Oct 26, 2021
@andrewrk andrewrk added this to the 0.9.0 milestone Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Observed behavior contradicts documented or intended behavior stage1 The process of building from source via WebAssembly and the C backend.
Projects
None yet
Milestone
0.9.0
Development

Successfully merging a pull request may close this issue.

Don't call render_const_val_array() on undefined jmc-88/zig
2 participants
@andrewrk @jmc-88