stage2 test-run-translated-c test "boolean values and expressions" produces old function pointer semantics

[andrewrk]

[nix-shell:~/Downloads/zig/build-release]$ time stage2/bin/zig build test-run-translated-c
/home/andy/.cache/zig/o/f2302a0f9c1008101cfc5ce3b88e5ebc/source.zig:448:32: error: expected pointer, found 'fn(c_int, c_int) callconv(.C) void'
    var self: bool = @ptrToInt(foo) != 0;
                               ^~~
error: run-translated-c boolean values and expressions build-exe...

[ehaas]

Do we need to change how we translate this, or is this a bug in stage2's ptrToInt?

[Vexu]

I think this can be argued in either way, since translate-c is passing a function when a pointer is expected but other places in stage2 support implicit casts from functions to function pointers. I tried to fix this in translate-c earlier today and it turned out to be more complicated than I anticipated.

[andrewrk]

Good point about implicit casts from functions to function pointers. I'm fine with solving this in Sema.

[andrewrk]

Hmm I actually changed my mind about this one. I know it's annoying but I think this needs to be a translate-c change. The problem is that @ptrToInt is one of the most unsafe operations we have, and so I think it makes sense for it to not do any implicit coercions on the operand. We don't want anyone accidentally passing a wrong identifier to @ptrToInt, but because it was a function (of which many identifiers are!), it passed the type-check.