Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement formal way to SKIP tests #1274

Closed
kristate opened this issue Jul 21, 2018 · 1 comment · Fixed by #1275
Closed

Implement formal way to SKIP tests #1274

kristate opened this issue Jul 21, 2018 · 1 comment · Fixed by #1275

Comments

@kristate
Copy link
Contributor

Instead of blindly passing tests for non-implemented features, it would be nice to be able to skip a test formally.

Once example of such a useful place is tcp.zig:

zig/std/event/tcp.zig

Lines 125 to 129 in b6eb404

test "listen on a port, send bytes, receive bytes" {
if (builtin.os != builtin.Os.linux) {
// TODO build abstractions for other operating systems
return;
}

I don't like posting issues without writing some sort of proposal or implementation, so I will spend some time looking at the internals, too. Could possibly ride ontop of the error framework: error.skip ?

kristate added a commit to kristate/zig that referenced this issue Jul 21, 2018
tracking issue ziglang#1274;

tests can be skipped by returnning `error.skip` :
kristate added a commit to kristate/zig that referenced this issue Jul 21, 2018
@kristate
Copy link
Contributor Author

Implemented in PR #1275

kristate added a commit to kristate/zig that referenced this issue Jul 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant