Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --build-id flag #3047

Closed
daurnimator opened this issue Aug 11, 2019 · 3 comments
Closed

Add --build-id flag #3047

daurnimator opened this issue Aug 11, 2019 · 3 comments
Assignees
@andrewrk
Labels
accepted This proposal is planned. contributor friendly This issue is limited in scope and/or knowledge of Zig internals. enhancement Solving this issue will likely involve adding new logic or components to the codebase. proposal This issue suggests modifications. If it also has the "accepted" label then it is planned.
Milestone
0.10.0

Comments

@daurnimator
Copy link
Collaborator

Related to #3014

zig commands such as build-exe should take a --build-id flag to specify the build id.

See https://fedoraproject.org/wiki/Releases/FeatureBuildId#Unique_build_ID
@daurnimator daurnimator added enhancement Solving this issue will likely involve adding new logic or components to the codebase. proposal This issue suggests modifications. If it also has the "accepted" label then it is planned. labels Aug 11, 2019
@andrewrk andrewrk added this to the 0.6.0 milestone Aug 11, 2019
@daurnimator daurnimator mentioned this issue Feb 5, 2020
Open
@andrewrk andrewrk modified the milestones: 0.6.0, 0.7.0 Feb 11, 2020
@daurnimator daurnimator mentioned this issue Aug 11, 2020
Merged
@andrewrk andrewrk modified the milestones: 0.7.0, 0.8.0 Oct 17, 2020
@daurnimator daurnimator mentioned this issue May 15, 2021
Merged
@andrewrk andrewrk modified the milestones: 0.8.0, 0.9.0 May 19, 2021
@andrewrk andrewrk modified the milestones: 0.9.0, 0.10.0 Nov 23, 2021
@andrewrk andrewrk mentioned this issue Jan 26, 2022
Closed
@andrewrk andrewrk modified the milestones: 0.10.0, 0.11.0 Apr 16, 2022
@andrewrk
Copy link
Member

The link is dead - can you expand on this?

@andrewrk andrewrk added the accepted This proposal is planned. label May 26, 2022
@andrewrk andrewrk modified the milestones: 0.11.0, 0.10.0 May 26, 2022
@andrewrk andrewrk added the contributor friendly This issue is limited in scope and/or knowledge of Zig internals. label May 26, 2022
@andrewrk andrewrk mentioned this issue May 26, 2022
Closed
@nektro
Copy link
Contributor

nektro commented May 26, 2022

https://web.archive.org/web/20210621234120/https://fedoraproject.org/wiki/Releases/FeatureBuildId live link

@andrewrk andrewrk self-assigned this May 31, 2022
andrewrk added a commit that referenced this issue Jul 19, 2022
@andrewrk
stage2: add support for -fbuild-id,-fno-build-id
abb48f3 
closes #3047
@Jan200101
Copy link
Contributor

This doesn't quite work because there are multiple different build-id types that no one can agree on.

simply adding --build-id to the linker call will use the fast build-id, while it may be desired to use a different one (md5,sha1,uuid)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrewrk andrewrk

Labels
accepted This proposal is planned. contributor friendly This issue is limited in scope and/or knowledge of Zig internals. enhancement Solving this issue will likely involve adding new logic or components to the codebase. proposal This issue suggests modifications. If it also has the "accepted" label then it is planned.
Projects
None yet
Milestone
0.10.0
Development

No branches or pull requests
4 participants
@andrewrk @daurnimator @nektro @Jan200101