Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

await @asyncCall and await async should generate the same code as a function call #3065

Open
andrewrk opened this issue Aug 15, 2019 · 0 comments
Open

await @asyncCall and await async should generate the same code as a function call #3065

andrewrk opened this issue Aug 15, 2019 · 0 comments
Labels
enhancement Solving this issue will likely involve adding new logic or components to the codebase. frontend Tokenization, parsing, AstGen, Sema, and Liveness. optimization
Milestone
0.15.0

Comments

@andrewrk
Copy link
Member

await async foo() is equivalent to foo() and should generate the same code.

await @asyncCall(...) is a different beast, but it can still be generated more efficiently than when the await is in a separate location.

I don't see any reason to bother with this for stage1.
@andrewrk andrewrk added enhancement Solving this issue will likely involve adding new logic or components to the codebase. optimization labels Aug 15, 2019
@andrewrk andrewrk added this to the 0.6.0 milestone Aug 15, 2019
@andrewrk andrewrk added the frontend Tokenization, parsing, AstGen, Sema, and Liveness. label Aug 15, 2019
@andrewrk andrewrk mentioned this issue Aug 15, 2019
Closed
10 tasks
andrewrk added a commit that referenced this issue Aug 31, 2019
@andrewrk
improvements to @asyncCall
5c3a9a1 
 * `await @asyncCall` generates better code. See #3065
 * `@asyncCall` works with a real `@Frame(func)` in addition to
   a byte slice. Closes #3072
 * `@asyncCall` allows passing `{}` (a void value) as the result
   pointer, which uses the result location inside the frame.
   Closes #3068
 * support `await @asyncCall` on a non-async function. This is in
   preparation for safe recursion (#1006).
@andrewrk andrewrk modified the milestones: 0.6.0, 0.7.0 Feb 11, 2020
@andrewrk andrewrk modified the milestones: 0.7.0, 0.8.0 Oct 17, 2020
@andrewrk andrewrk modified the milestones: 0.8.0, 0.9.0 Jun 4, 2021
@andrewrk andrewrk modified the milestones: 0.9.0, 0.10.0 Nov 21, 2021
@andrewrk andrewrk modified the milestones: 0.10.0, 0.11.0 Apr 17, 2022
@andrewrk andrewrk modified the milestones: 0.11.0, 0.12.0 Apr 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Solving this issue will likely involve adding new logic or components to the codebase. frontend Tokenization, parsing, AstGen, Sema, and Liveness. optimization
Projects
None yet
Milestone
0.15.0
Development

No branches or pull requests
1 participant
@andrewrk