Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

empty_env standalone test may fail depending on the environment #3168

Open
Sahnvour opened this issue Sep 3, 2019 · 0 comments · May be fixed by #18969
Open

empty_env standalone test may fail depending on the environment #3168

Sahnvour opened this issue Sep 3, 2019 · 0 comments · May be fixed by #18969
Milestone

Comments

@Sahnvour
Copy link
Contributor

Sahnvour commented Sep 3, 2019

I sometimes use ConEmu as my terminal emulator on windows. Under ConEmu, the empty_env test fails because the envmap is not empty.

Output added for debug:

$ zig build test-standalone -Dskip-release -Dtest-filter=empty
KV{ .key = ANSICON_DEF, .value = 7 }
KV{ .key = ANSICON, .value = 182x1000 (182x42) }
KV{ .key = ConEmuANSI, .value = ON }
test failure
...

It appears it defines these variables for compatibility with ansicon, but I don't know how it is injected into the child process.

Related documentation:
https://conemu.github.io/en/ConEmuEnvironment.html
https://conemu.github.io/en/AnsiEscapeCodes.html

@Sahnvour Sahnvour added this to the 0.6.0 milestone Sep 3, 2019
@andrewrk andrewrk modified the milestones: 0.6.0, 0.7.0 Feb 11, 2020
@andrewrk andrewrk modified the milestones: 0.7.0, 0.8.0 Oct 17, 2020
@andrewrk andrewrk modified the milestones: 0.8.0, 0.9.0 Nov 6, 2020
@andrewrk andrewrk modified the milestones: 0.9.0, 0.10.0 May 19, 2021
Parzival-3141 added a commit to Parzival-3141/zig that referenced this issue Feb 17, 2024
Closes ziglang#13685
Closes ziglang#3168

The problem seems to be ConEmu setting environment variables before
executing the test process. The test passes when run in Windows CMD.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants