compiler segfaults with async fn call with tuple after integer parameter

[andrewrk]

const std = @import("std");

export fn foo() void {
    _ = async bar(1, .{});
}

fn bar(ptr: i32, args: var) anyerror!void {
    suspend;
}

pub fn panic(msg: []const u8, stack_trace: ?*const std.builtin.StackTrace) noreturn {
    @breakpoint();
    unreachable;
}

[andrewrk]

fix:

--- a/src/codegen.cpp
+++ b/src/codegen.cpp
@@ -365,7 +365,7 @@ static uint32_t frame_index_arg(CodeGen *g, ZigType *return_type) {
 static uint32_t frame_index_trace_stack(CodeGen *g, FnTypeId *fn_type_id) {
     uint32_t result = frame_index_arg(g, fn_type_id->return_type);
     for (size_t i = 0; i < fn_type_id->param_count; i += 1) {
-        if (type_has_bits(fn_type_id->param_info->type)) {
+        if (type_has_bits(fn_type_id->param_info[i].type)) {
             result += 1;
         }
     }

[andrewrk]

Next problem:

const std = @import("std");

export fn foo() void {
    var a: u128 = 1;
    _ = async bar(undefined, .{a});
}

fn bar(ptr: *i32, args: var) anyerror!void {
    suspend;
}

pub fn panic(msg: []const u8, stack_trace: ?*const std.builtin.StackTrace) noreturn {
    @breakpoint();
    unreachable;
}

[andrewrk]

analyze.cpp has this logic:

            if (next_offset > llvm_next_offset) {
                size_t pad_bytes = next_offset - (field->offset + LLVMStoreSizeOfType(g->target_data_ref, llvm_type));
                if (pad_bytes != 0) {
                    LLVMTypeRef pad_llvm_type = LLVMArrayType(LLVMInt8Type(), pad_bytes);
                    element_types[gen_field_index] = pad_llvm_type;
                    gen_field_index += 1;
                }
            }

codegen.cpp has this logic:

static uint32_t frame_index_trace_stack(CodeGen *g, FnTypeId *fn_type_id) {
    uint32_t result = frame_index_arg(g, fn_type_id->return_type);
    for (size_t i = 0; i < fn_type_id->param_count; i += 1) {
        if (type_has_bits(fn_type_id->param_info[i].type)) {
            result += 1;
        }
    }
    return result;
}

This is a regression from when structs gained the ability to have padding beyond what LLVM provides.

[andrewrk]

fix:

--- a/src/codegen.cpp
+++ b/src/codegen.cpp
@@ -362,14 +362,16 @@ static uint32_t frame_index_arg(CodeGen *g, ZigType *return_type) {
 }
 
 // label (grep this): [fn_frame_struct_layout]
-static uint32_t frame_index_trace_stack(CodeGen *g, FnTypeId *fn_type_id) {
-    uint32_t result = frame_index_arg(g, fn_type_id->return_type);
-    for (size_t i = 0; i < fn_type_id->param_count; i += 1) {
-        if (type_has_bits(fn_type_id->param_info->type)) {
-            result += 1;
-        }
+static uint32_t frame_index_trace_stack(CodeGen *g, ZigFn *fn) {
+    size_t field_index = 6;
+    bool have_stack_trace = codegen_fn_has_err_ret_tracing_arg(g, fn->type_entry->data.fn.fn_type_id.return_type);
+    if (have_stack_trace) {
+        field_index += 2;
     }
-    return result;
+    field_index += fn->type_entry->data.fn.fn_type_id.param_count;
+    ZigType *locals_struct = fn->frame_type->data.frame.locals_struct;
+    TypeStructField *field = locals_struct->data.structure.fields[field_index];
+    return field->gen_index;
 }
 
 
@@ -7742,7 +7744,7 @@ static void do_code_gen(CodeGen *g) {
             }
             uint32_t trace_field_index_stack = UINT32_MAX;
             if (codegen_fn_has_err_ret_tracing_stack(g, fn_table_entry, true)) {
-                trace_field_index_stack = frame_index_trace_stack(g, fn_type_id);
+                trace_field_index_stack = frame_index_trace_stack(g, fn_table_entry);
                 g->cur_err_ret_trace_val_stack = LLVMBuildStructGEP(g->builder, g->cur_frame_ptr,
                         trace_field_index_stack, "");
             }