std.fmt.fmtIntSizeDec() and fmtIntSizeBin() do not consider FormatOptions

[mikdusan]

Ultimately formatSizeImpl() is used to implement fmtIntSizeDec() or fmtIntSizeBin() and it does not consider FormatOptions and probably should.

motivating example (from @espindola via IRC):

const std = @import("std");

pub fn main() !void {
    const stdout = std.io.getStdOut().writer();

    var buf: [32]u8 = undefined;
    var slice = buf[0..];
    const partial = try std.fmt.bufPrint(slice, "{}", .{std.fmt.fmtIntSizeDec(42 * 1000)});

    try stdout.print("X {s:<14} Y\n", .{partial});
    try stdout.print("X {:<14} Y\n", .{std.fmt.fmtIntSizeDec(42 * 1000)});
}

$ zig run foo.zig
X 42kB           Y
X 42kB Y

@andrewrk you mentioned in IRC:

it should also be renamed to remove the redundant fmt

There is a pattern in std.fmt where all pub fn fmt*() functions return a Formatter() object; a grep follows. Do you want these renamed like fmtFirstSecond() → firstSecond()?

pub fn fmtSliceHexLower(bytes: []const u8) std.fmt.Formatter(formatSliceHexLower) {
pub fn fmtSliceHexUpper(bytes: []const u8) std.fmt.Formatter(formatSliceHexUpper) {
pub fn fmtSliceEscapeLower(bytes: []const u8) std.fmt.Formatter(formatSliceEscapeLower) {
pub fn fmtSliceEscapeUpper(bytes: []const u8) std.fmt.Formatter(formatSliceEscapeUpper) {
pub fn fmtIntSizeDec(value: u64) std.fmt.Formatter(formatSizeDec) {
pub fn fmtIntSizeBin(value: u64) std.fmt.Formatter(formatSizeBin) {
pub fn fmtDuration(ns: u64) Formatter(formatDuration) {

[ghost]

Another issue where it seems like a PR has been merged but the issue is still open. Can this be closed?

[Vexu]

That PR did not address this issue.

[ghost]

Oh, I see - that PR handled a similar issue with different functions. I'll see if I can do this one myself.