Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added implementation for _fseeki64 and _ftelli64 from mingw-w64 9.0.0 (#9402). #9766

Merged
merged 4 commits into from Sep 15, 2021
Merged

Added implementation for _fseeki64 and _ftelli64 from mingw-w64 9.0.0 (#9402). #9766

merged 4 commits into from Sep 15, 2021

Conversation

michal-z
Copy link
Contributor

Fixes #9402.

marler8997
marler8997 reviewed Sep 14, 2021
View reviewed changes
Copy link
Contributor

@marler8997 marler8997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

file contents look correct.

It would be great if we could add a test that calls these 2 functions to make sure they exist!

marler8997
marler8997 approved these changes Sep 15, 2021
View reviewed changes
Copy link
Contributor

@marler8997 marler8997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice, thanks for adding a test

@michal-z michal-z mentioned this pull request Sep 15, 2021
Closed
@andrewrk andrewrk merged commit e06052f into ziglang:master Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marler8997 marler8997 marler8997 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lld-link error with Zig 0.8.0 on Windows, undefined symbols '_fseeki64' and '_ftelli64'
3 participants
@michal-z @marler8997 @andrewrk