Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various build options (OptionsStep) fixes #10016

Merged
merged 6 commits into from
Nov 16, 2021

Conversation

courajs
Copy link
Contributor

@courajs courajs commented Oct 23, 2021

  • There was code to format a std.builtin.Version, but it was untested, and actually fell through to the default case, declaring the constant a second time, as an invalid expression.
  • Because we're doing custom code formatting here, I added a check that the generated code is still valid zig syntax
  • Fix specifying enum values with names that are not valid identifiers (fixes Build options cannot be set to enum values which are not valid identifiers #10013)
  • Allow arbitrary slices and arrays of primitives
  • Add explicit error messaging when an invalid type/value is passed, rather than just generating some invalid code

@courajs
Copy link
Contributor Author

courajs commented Oct 26, 2021

Not sure the Azure build failure is related to these changes - the tests were running but the job timed out. Maybe another manifestation of #6467?

@courajs
Copy link
Contributor Author

courajs commented Oct 26, 2021

Ah, or #10008! No rush

@andrewrk andrewrk merged commit c587be7 into ziglang:master Nov 16, 2021
@andrewrk
Copy link
Member

Thanks!

@courajs courajs deleted the array-build-options branch November 16, 2021 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build options cannot be set to enum values which are not valid identifiers
2 participants