restore compatibility with glibc<=2.33 for global initializers #10587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xxxbxxx
changed the title
|
This looks reasonable, thanks! I'll add another commit with some minor organization and then merge. |
__libc_start_main() from glibc.2.33.so or older needs to have a __libc_csu_init function callback parameter. glibc-2.34 on the other hand has a different __libc_start_main() that does not use it, and the start.S file from glibc-2.34 no longer construct the init function and pass null when calling __libc_start_main. So, When targetting an older glibc, use the start.s files as they were in glibc-2.33 and construct the __libc_csu_init function. fixes ziglang#10386 ziglang#10512
also use the common naming convention for glibc versions ("2.33" rather
than "2-33").
I also verified that these files are exactly identical to the previous
files from before zig updated to glibc 2.34.
uhthomas
pushed a commit
to gmirror/bazel-zig-cc
that referenced
this pull request
Jan 15, 2022
Thanks Xavier for ziglang/zig#10587
scorphus
pushed a commit
to scorphus/zig
that referenced
this pull request
Jan 15, 2022
restore compatibility with glibc<=2.33 for global initializers
andrewrk
added a commit
that referenced
this pull request
Feb 3, 2022
restore compatibility with glibc<=2.33 for global initializers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tentative fix for #10386 #10512
I've just conditionally restored some code from before 19ca241
to get _start to pass an init() fonction to __libc_start_main.
appears to work, but I've just tested with system glibc 2.33. (didn't test for no regression in 2.34 for ex.)
Is this the correct thing to do?
I've manually restored the old files, expecting this to be done 'once' and the files kept unchanged for future glibc versions. But maybe it is needed to update the tools/upadte_glibc?