std.mem.Allocator: replace create signature with construct signature #1141

kristate · 2018-06-20T15:42:59Z

/// Call destroy with the result	
/// TODO once #733 is solved, this will replace create	
pub fn construct(self: *Allocator, init: var) Error!*@typeOf(init) {

…iglang#733

Hejsil · 2018-06-20T16:06:09Z

std/mem.zig

+    /// Alias of create
+    /// Call destroy with the result
+    pub fn construct(self: *Allocator, init: var) Error!*@typeOf(init) {
+      debug.warn("std.mem.Allocator.construct is deprecated;\n");


I think we should just remove it. Zig has few users, no big codebases (std is the biggest) and there have already been many breaking changes over the past month :)
Besides, if create's signature is changed anyways, then this is already a breaking change

@andrewrk thoughts?

Oops, saw this just now after I already merged it. I agree with @Hejsil's logic and I removed it in a fixup commit as part of merging. 👍

Hejsil · 2018-06-20T16:08:45Z

std/linked_list.zig

@@ -193,7 +193,11 @@ fn BaseLinkedList(comptime T: type, comptime ParentType: type, comptime field_na
        ///     A pointer to the new node.
        pub fn allocateNode(list: *Self, allocator: *Allocator) !*Node {
            comptime assert(!isIntrusive());
-            return allocator.create(Node);
+            return allocator.create(Node{


It probably doesn't matter too much, but the right replacement is probably return allocator.create(Node(undefined));

Cool, I was wondering about this!

andrewrk · 2018-06-20T21:11:46Z

Looks great! Congrats on your first PR.

kristopher tate added 2 commits June 21, 2018 00:39

std.mem: remove allocator create in favor of construct; ref ziglang#733

457c0f0

std: update stdlib to match updated allocator create signature; ref z…

71db8df

…iglang#733

Hejsil reviewed Jun 20, 2018

View reviewed changes

kristopher tate added 2 commits June 21, 2018 01:39

std.mem.Allocator.construct: remove deprecation warning;

4b46af4

std.mem.Allocator.construct: improve formatting;

6bd8610

andrewrk merged commit 6bd8610 into ziglang:master Jun 20, 2018

kristate deleted the stdmem-replace-create-with-construct branch June 21, 2018 05:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

std.mem.Allocator: replace create signature with construct signature #1141

std.mem.Allocator: replace create signature with construct signature #1141

kristate commented Jun 20, 2018 •

edited

Hejsil Jun 20, 2018

kristate Jun 20, 2018

andrewrk Jun 20, 2018

Hejsil Jun 20, 2018

kristate Jun 20, 2018

andrewrk commented Jun 20, 2018

std.mem.Allocator: replace create signature with construct signature #1141

std.mem.Allocator: replace create signature with construct signature #1141

Conversation

kristate commented Jun 20, 2018 • edited

Hejsil Jun 20, 2018

Choose a reason for hiding this comment

kristate Jun 20, 2018

Choose a reason for hiding this comment

andrewrk Jun 20, 2018

Choose a reason for hiding this comment

Hejsil Jun 20, 2018

Choose a reason for hiding this comment

kristate Jun 20, 2018

Choose a reason for hiding this comment

andrewrk commented Jun 20, 2018

kristate commented Jun 20, 2018 •

edited