Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix another LockViolation case on Windows #14162

Merged
merged 4 commits into from Jan 4, 2023
Merged

Fix another LockViolation case on Windows #14162

merged 4 commits into from Jan 4, 2023

Commits on Jan 2, 2023

  1. compilation: fix a LockViolation on Windows 

    - Add an assert that an exclusive lock is help to writeManifest
- Only call writeManifest in updateCObject if an exclusive lock is held
    @kcbanner
    kcbanner committed Jan 2, 2023
    Copy the full SHA
    9c73d5d View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2023

  1. cache: fixup test to verify hits don't take an exclusive lock, instea… 

    …d of writing the manifest
    @kcbanner
    kcbanner committed Jan 3, 2023
    Copy the full SHA
    1e9ee7e View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2023

  1. cache: more test fixups

    @kcbanner
    kcbanner committed Jan 4, 2023
    Copy the full SHA
    0dc3a9f View commit details
    Browse the repository at this point in the history

  2. compilation: fix calling writeManifest without an exclusive lock in c… 

    …Import
    @kcbanner
    kcbanner committed Jan 4, 2023
    Copy the full SHA
    98b67a2 View commit details
    Browse the repository at this point in the history