Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#12474: std.fs.Dir.makeOpenPath: optimize case, if path already exists #14833

Merged
merged 4 commits into from
Oct 22, 2023
Merged

#12474: std.fs.Dir.makeOpenPath: optimize case, if path already exists #14833

merged 4 commits into from
Oct 22, 2023

Commits on Oct 19, 2023

  1. std.fs.Dir.makeOpenPath: optimize when path already exists 

    Uses a single NtCreateFile syscall on windows.

Closes ziglang#12474. Thanks to @joedavis and @matu3ba.
    @QusaiHroub @andrewrk
    QusaiHroub authored and andrewrk committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    f6a6cdb View commit details
    Browse the repository at this point in the history

  2. path.ComponentIterator: Add peekNext and peekPrevious functions

    @squeek502 @andrewrk
    squeek502 authored and andrewrk committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    c139b9d View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2023

  1. Dir.makeOpenPathAccessMaskW: Use path.ComponentIterator 

    See 49053cb for details

Also, fix leaking the intermediate directory handles.
    @squeek502
    squeek502 committed Oct 21, 2023
    Configuration menu
    Copy the full SHA
    63b5042 View commit details
    Browse the repository at this point in the history

  2. Improve Dir.makePath and Dir.makeOpenPathAccessMaskW doc comments 

    These are not recursive functions, so 'recursively' could be misleading.
    @squeek502
    squeek502 committed Oct 21, 2023
    Configuration menu
    Copy the full SHA
    fb5f69a View commit details
    Browse the repository at this point in the history