Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

somewhat realistic usecase test for shifting strange integer sizes #1543

Merged
merged 1 commit into from Sep 18, 2018
Merged

somewhat realistic usecase test for shifting strange integer sizes #1543

merged 1 commit into from Sep 18, 2018
+87 −0

Conversation

thejoshwolfe
Copy link
Sponsor Contributor

proof of concept. I guess this could be merged (and squashed) as a test.

@andrewrk
Copy link
Member

This doesn't need to be a standalone test, which has a slightly higher CI time cost than behavioral tests.

  • move main.zig to test/cases/your_name_here.zig
  • add the line in test/behavior.zig to include your_name_here.zig
  • delete build.zig
  • now your test is included when the behavior tests are run.

@thejoshwolfe thejoshwolfe mentioned this pull request Sep 18, 2018
Closed
andrewrk
andrewrk approved these changes Sep 18, 2018
View reviewed changes
Copy link
Member

@andrewrk andrewrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merge at will

@thejoshwolfe thejoshwolfe merged commit 8f0618a into master Sep 18, 2018
@thejoshwolfe thejoshwolfe deleted the bit_shifting branch September 18, 2018 01:07
@thejoshwolfe thejoshwolfe mentioned this pull request Sep 18, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewrk andrewrk andrewrk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thejoshwolfe @andrewrk