Follow-up to #19414 #19437
Merged
Follow-up to #19414 #19437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note to avoid blindsiding Andrew: merging this PR would implement #19435. |
`Decl` can no longer store un-interned values, so this field is now unnecessary. The type can instead be fetched with the new `typeOf` helper method, which just gets the type of the Decl's `Value`.
…utable memory Perhaps someday, we will make Sema operate on mutable values more generally. For now, it makes sense to split out this representation, since it is only used in comptime pointer accesses. There are some currently unused methods on `MutableValue` which will be used once I rewrite the comptime pointer access logic to be less terrible. The commit following this one will - at long last - delete the legacy Value representation
Good riddance! Most of these changes are trivial. There's a fix for a minor bug this exposed in `Value.readFromPackedMemory`, but aside from that, it's all just things like changing `intern` calls to `toIntern`.
This commit also performs some refactors to `TypedValue.print` in preparation for improved comptime pointer access logic. Once that logic exists, `TypedValue.print` can use Sema to access pointers for more helpful printing. This commit also implements proposal ziglang#19435, because the existing logic there relied on some blatantly incorrect code in `Value.sliceLen`. Resolves: ziglang#19435
Legacy anon decls now have three uses: * Type owner decls * Function owner decls * `@export` and `@extern` Therefore, there are no longer any cases where we wish to explicitly omit legacy anon decls from the binary. This means we can remove the concept of an "alive" vs "dead" `Decl`, which also allows us to remove the separate `anon_work_queue` in `Compilation`.
Now that the legacy `Value` representation is eliminated, we can begin to phase out the redundant `TypedValue` type.
…n decls Also removes some unnecessary uses of legacy anon decls for constructing the array of test functions for the test runner.
The only logic which remained in this file was the Value printing logic. This has been moved into a new `print_value.zig`.
mlugg
force-pushed
the
value-cleanups
branch
2 times, most recently
from
cacee1a
to
a546258
Compare
Notably, this improves string printing from `@as(*[5:0]u8, &@as([5:0]u8, "hello".*))` to `@as(*[5:0]u8, "hello")`, omitting the pointless ref-deref pair.
andrewrk
approved these changes
Mar 26, 2024
|
Oh, yep! I'll do that in a moment, and have a quick check for any more newly-unused functions. |
|
Not "newly" unused, but there were quite a few old methods on |
Feel free to merge when the only remaining checks are aarch64-macos. We're expecting those runners to be offline for one day. |
|
AFAICT my permissions don't allow me to manually merge through the GitHub UI. I could do it on the command-line (I assume; I can't say I've ever tried to push to master), but IME GitHub is pretty piss-poor at detecting that as a merge. Is it possible to get the relevant permission to do the merge on GitHub? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages for more details. To summarize:
tyfield ofZcu.DeclMutableValuerepresentation for comptime-mutable memoryValuerepresentationDecl" systemTypedValue