std.meta.hasUniqueRepresentation: better support packed structs #20143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlugg
requested changes
Jun 2, 2024
Co-authored-by: Matthew Lugg <mlugg@mlugg.co.uk>
WillLillis
reviewed
Jun 2, 2024
| @@ -1200,6 +1200,8 @@ pub inline fn hasUniqueRepresentation(comptime T: type) bool { | |||
| .Array => |info| hasUniqueRepresentation(info.child), | |||
|
|
|||
| .Struct => |info| { | |||
| if (info.layout == .@"packed") return @sizeOf(T) * 8 == @bitSizeOf(T); | |||
There was a problem hiding this comment.
Would it be better to use byte_size_in_bits over 8 here based on this comment:
Lines 23 to 29 in d74180c
Apologies if I'm misunderstanding anything :)
There was a problem hiding this comment.
yes but i dont think that assumption will realistically ever be broken. additionally a pass would have to be done over the entire stdlib and compiler to use that constant since its a very new addition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17592