detect the windows um include directory #3343
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous versions of Windows had a path like this:
C:\Program Files (x86)\Windows Kits\10\Include\10.0.10150.0\ucrt
And that had all the .h files in it. However every ucrt newer than that, including the newest one, look like this:
C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0
, with subdirs:cppwinrt
shared
ucrt
um
winrt
The
um
andshared
directories have .h files that are desired when linking libc. For example, if you try to depend on GLFW, it's going to try to#include <GL/gl.h>
(found in theum
dir), which itself will#include <winapifamily.h>
(found in theshared
dir).This pull requests adds the
um
andshared
directories to the list of include directories when targeting windows and linking libc.