Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect the windows um include directory #3343

Merged
merged 2 commits into from Sep 29, 2019
Merged

Conversation

andrewrk
Copy link
Member

@andrewrk andrewrk commented Sep 29, 2019

Previous versions of Windows had a path like this: C:\Program Files (x86)\Windows Kits\10\Include\10.0.10150.0\ucrt

And that had all the .h files in it. However every ucrt newer than that, including the newest one, look like this: C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0, with subdirs:

  • cppwinrt
  • shared
  • ucrt
  • um
  • winrt

The um and shared directories have .h files that are desired when linking libc. For example, if you try to depend on GLFW, it's going to try to #include <GL/gl.h> (found in the um dir), which itself will #include <winapifamily.h> (found in the shared dir).

This pull requests adds the um and shared directories to the list of include directories when targeting windows and linking libc.

@andrewrk andrewrk merged commit ffaf37a into master Sep 29, 2019
@andrewrk andrewrk deleted the windows-libc-um-dir branch September 29, 2019 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant