introduce std.fs.Dir.openFile and std.fs.Dir.createFile #3813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These functions have flags parameters which cover all the use cases. The other functions are now deprecated.
update to non-deprecated std.fs APIs throughout the codebase Related: #3811
andrewrk
added
breaking
daurnimator
requested changes
Nov 30, 2019
| return File{ .handle = fd }; | ||
| } | ||
|
|
||
| /// Same as `createFile` but the path parameter is WTF-16 encoded. |
There was a problem hiding this comment.
It's not entirely the same, as it doesn't support non-windows.
Also the encoding is UCS-2. WTF-16 isn't a thing (though WTF-8 is)
There was a problem hiding this comment.
It's a reference to https://simonsapin.github.io/wtf-8/#wtf-16. I think this is different than UCS-2
There was a problem hiding this comment.
I'll further improve the docs it to make it clear though 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These functions have flags parameters which cover all the use cases. The other functions are now deprecated.
std.fs.openFileAbsoluteand related functions are also added. It should now be clear the pattern that the standard library file system API is approaching. The API encourages programmers to take advantage of directory traversal via directory handles, for better general protection against Time Of Check, Time Of Use bugs across all Zig codebases.This PR also moves
std.fs.Dir.cwdtostd.fs.cwd, which is a breaking change. Other functions remain deprecated, to be removed with #3811.