ci/azure/on_master_success: adapt script for Microsoft's unannounced repo changes #3901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
euantorano
suggested changes
Dec 13, 2019
i should not write code at midnight
andrewrk
reviewed
Dec 13, 2019
| @@ -5,7 +5,7 @@ set +x | |||
|
|
|||
| set -e | |||
|
|
|||
| sudo apt-get update -y | |||
| sudo apt-get update -y --allow-releaseinfo-change | |||
There was a problem hiding this comment.
why is this required here but not here?
Line 11 in e54c49b
|
I appreciate this PR but I'd rather not merge it, if Microsoft fixes the problem. I suspect this may be a short-lived problem with them rolling out a new version. On the plus side, it now lets you see logs before the job finishes. |
|
Microsoft fixed their shit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR: Microsoft changed some of its repository metadata for their APT repo. This Ubuntu image we were using was not expecting that.
--allow-releaseinfo-changeis passed toapt-getso the script works like expected.