Fix std.child_process.ChildProcess.spawnWindow when app_name is relative #4137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daurnimator
added
os-windows
standard library
…nvironment variable, it applied cwd+app_name instead of just using the app_name
mlarouche
force-pushed
the
fix_addSystemCommand_windows
branch
from
421fa64
to
e0a53d1
Compare
|
This will help me removing that hardcoded path in my project: https://github.com/wendigojaeger/ZigGBA/blob/master/GBA/builder.zig#L75 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When looking in PATH environment variable, it looked for PATH+cwd+app_name instead of just using PATH+app_name