zig cc: add support for -L linker arguments #4893
Conversation
|
So you should be able to add: .{
.name = "library-directory",
.ident = "linker_input_l",
},
.{
.name = "library-directory=",
.ident = "linker_input_l",
},to |
|
Note that the script will try appending a |
src/main.cpp
Outdated
| linker_args.append(buf_create_from_str("-L")); | ||
| linker_args.append(buf_create_from_str(it.only_arg)); |
There was a problem hiding this comment.
Instead of this you can simply do:
lib_dirs.append(it.only_arg);This matches the -L parameter from zig command line which you can see earlier in the file.
tools/update_clang_options.zig
Outdated
| @@ -223,7 +227,7 @@ pub fn main() anyerror!void { | |||
| try std.fmt.allocPrint(allocator, "-I={}/clang/include/clang/Driver", .{llvm_src_root}), | |||
| }; | |||
|
|
|||
| const child_result = try std.ChildProcess.exec(.{ | |||
| const child_result = try std.ChildProcess.exec2(.{ | |||
There was a problem hiding this comment.
if you update to zig master branch then exec will be correct
Thanks for the contribution! |
src/main.cpp
Outdated
| @@ -790,6 +794,9 @@ static int main0(int argc, char **argv) { | |||
| buf_eql_str(arg, "-export-dynamic")) | |||
| { | |||
| rdynamic = true; | |||
| } else if (buf_eql_str(arg, "-L")) { | |||
| i += 1; | |||
| lib_dirs.append(buf_ptr(linker_args.at(i))); | |||
There was a problem hiding this comment.
Should I remove this change since I'm now adding to lib_dirs directly instead of adding to linker_args?
redj
force-pushed
the
zig-cc-add-linker-flag-l
branch
from
7162bc0
to
7be005a
Compare
redj
force-pushed
the
zig-cc-add-linker-flag-l
branch
from
7be005a
to
dfe33e6
Compare
|
Nice work! |
This is my first zig change. Do I need to run any tests? or add any test cases?
edit: This is towards the completion of zig cc (#4784)