Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multiplication overflow in hash_const_val #4910

Merged
merged 1 commit into from
Apr 2, 2020
Merged

Fix multiplication overflow in hash_const_val #4910

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/analyze.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5361,7 +5361,7 @@ static uint32_t hash_const_val(ZigValue *const_val) {
return result;
}
case ZigTypeIdEnumLiteral:
return buf_hash(const_val->data.x_enum_literal) * 2691276464;
return buf_hash(const_val->data.x_enum_literal) * (uint32_t)2691276464;
case ZigTypeIdEnum:
{
uint32_t result = 31643936;
Expand Down Expand Up @@ -5429,12 +5429,12 @@ static uint32_t hash_const_val(ZigValue *const_val) {
return 2709806591;
case ZigTypeIdOptional:
if (get_src_ptr_type(const_val->type) != nullptr) {
return hash_const_val_ptr(const_val) * 1992916303;
return hash_const_val_ptr(const_val) * (uint32_t)1992916303;
} else if (const_val->type->data.maybe.child_type->id == ZigTypeIdErrorSet) {
return hash_const_val_error_set(const_val) * 3147031929;
return hash_const_val_error_set(const_val) * (uint32_t)3147031929;
} else {
if (const_val->data.x_optional) {
return hash_const_val(const_val->data.x_optional) * 1992916303;
return hash_const_val(const_val->data.x_optional) * (uint32_t)1992916303;
} else {
return 4016830364;
}
Expand Down