Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make zig work on OSX via -DZIG_WORKAROUND_4799=ON #5092

Closed
wants to merge 1 commit into from
Closed

make zig work on OSX via -DZIG_WORKAROUND_4799=ON #5092

wants to merge 1 commit into from

Conversation

timotheecour
Copy link
Contributor

@timotheecour timotheecour commented Apr 18, 2020 •
edited
Loading

@timotheecour timotheecour changed the title refs https://github.com/ziglang/zig/issues/4799 make zig work on OSX via -DZIG_WORKAROUND_4799=ON Apr 18, 2020
@timotheecour timotheecour mentioned this pull request Apr 18, 2020
Closed
4 tasks
@tritao tritao mentioned this pull request Apr 21, 2020
Closed
@timotheecour
Copy link
Contributor Author

timotheecour commented May 21, 2020 •
edited
Loading

ping @andrewrk (especially now that the overeager lock bot closed Homebrew/homebrew-core#53198)

andrewrk
andrewrk reviewed Jun 25, 2020
View reviewed changes
Copy link
Member

@andrewrk andrewrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I sincerely appreciate you taking the time to make this pull request.

However, I don't want to pile hacks upon hacks. I'm just going to leave this broken, with a documented manual workaround, until it's fixed upstream.

README.md
@@ -59,11 +59,13 @@ brew outdated llvm || brew upgrade llvm
mkdir build
cd build
cmake .. -DCMAKE_PREFIX_PATH=$(brew --prefix llvm)
make install
make -j install
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not advisable, will crash people's computers under common circumstances.

@andrewrk andrewrk closed this Jun 25, 2020
@timotheecour
Copy link
Contributor Author

timotheecour commented Jun 25, 2020 •
edited
Loading

However, I don't want to pile hacks upon hacks. I'm just going to leave this broken, with a documented manual workaround, until it's fixed upstream.

this makes no sense to me. The hack can be removed as soon as it's fixed upstream, it's better in all regards compared to forcing package managers (eg homebrew) to do those manual changes. It's not piling hacks upon hacks, it's just the simplest, practical, least friction solution for everyone.

@andrewrk
Copy link
Member

andrewrk commented Jul 3, 2020

this makes no sense to me. The hack can be removed as soon as it's fixed upstream, it's better in all regards compared to forcing package managers (eg homebrew) to do those manual changes. It's not piling hacks upon hacks, it's just the simplest, practical, least friction solution for everyone.

OK, I reconsidered and I agree with you, thanks for your patience.

@andrewrk andrewrk reopened this Jul 3, 2020
@andrewrk andrewrk closed this in 72cd11d Jul 3, 2020
@timotheecour timotheecour deleted the pr_fix_4799 branch July 3, 2020 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewrk andrewrk andrewrk left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timotheecour @andrewrk