WasmPageAllocator: fix bug not aligning allocations #5737
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements aligned allocations in
WasmPageAllocator
.My changes to arena allocator (#5736) exposed a bug in
WasmPageAllocator
when allocating a block aligned to262144
bytes. Note that this appears to be an existing bug unrelated to the new allocator changes, but exposed by them.WasmPageAllocator
was not aligning allocations, but its page size is64K
so the bug is unlikely to be triggered unless you are doing very highly aligned allocations.Here is the stacktrace of the bug: