make selfExePath() compile on OpenBSD #6788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e a [*:0]const u8
daurnimator
added
the
standard library
kubkon
reviewed
Oct 24, 2020
| @@ -2251,7 +2251,7 @@ pub fn selfExePath(out_buffer: []u8) SelfExePathError![]u8 { | |||
| const PATH = std.os.getenvZ("PATH") orelse return error.FileNotFound; | |||
| var path_it = mem.tokenize(PATH, &[_]u8{path.delimiter}); | |||
| while (path_it.next()) |a_path| { | |||
| var resolved_path_buf: [MAX_PATH_BYTES]u8 = undefined; | |||
| var resolved_path_buf: [MAX_PATH_BYTES-1:0]u8 = undefined; | |||
There was a problem hiding this comment.
I'm wondering, could this not be made into
var resolved_path_buf: [MAX_PATH_BYTES:0]u8 = undefined;instead?
There was a problem hiding this comment.
in #6638 (comment), I was told to use MAX_PATH_BYTES-1:0.
There was a problem hiding this comment.
Cool! I was just wondering why not MAX_PATH_BYTES + 1, but I guess it makes sense for it to be null-delimited, hence the null makes the last byte in MAX_PATH_BYTES. :-)
|
this PR is only to restore an already accepted change with was lost in the merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
readd original code from #6638. realpathZ() is expected to take a
[*:0]const u8