remove git diff feature from build.zig
#7542
Conversation
|
Nice one, thanks! I have run into this as well, and it was really annoying. However I do think it is weird that it returns StreamTooLong, shouldn't it just work even if the git output is really long? |
|
See std/build.zig:1027 it makes a relatavly small max size (1024 * 400).
…On Fri Dec 25, 2020 at 4:53 AM, Timon Kruiper wrote:
Nice one, thanks! I have run into this as well, and it was really
annoying. However I do think it is weird that it returns StreamTooLong,
shouldn't it just work even if the git output is really long?
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#7542 (comment)
|
|
Yes thanks for this. However I think it would be best to remove this code entirely from the build script. Compiler contributors will have to be aware that the cache compiler ID is not different based on working tree changes. In exchange for this we get a simpler build script, faster build, and ability to debug cache issues. |
g-w1
changed the title
git diff HEAD ran from build script was too long, it would failgit diff feature from build.zig
|
What about using something more compact like |
|
I think that would be a good bet if we wanted to keep this functionality. I say we move forward with removing it, try out development without it, and then we can see how it goes and reconsider adding it using the git diff raw format. Thanks for pointing that out; I was unaware of its existence. |
No description provided.