-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build and install documentation as part as the default build process #7911
Build and install documentation as part as the default build process #7911
Conversation
cb45262
to
239c650
Compare
239c650
to
6740b89
Compare
6740b89
to
8e19c24
Compare
@g-w1 I made doc an optional target, so that it only triggers if one runs |
You should also put documentation for this somewhere (pun intended). |
@g-w1 I made doc an optional target, so that it only triggers if one runs
That was a good one :-) I propose to update https://github.com/ziglang/zig/wiki/Building-Zig-From-Source once this PR is merged. |
There are various things missing in the CMakeLists.txt that are present in the build.zig so I wonder if that was on purpose |
@Jan200101 I don't know either. Is that blocking for this PR? |
I wouldn't call it blocking but its up in the air if this is desired behavior |
I don't see the point of doing this instead of |
|
It could be argued that the CMakeLists.txt is only there to get to a fully functional Zig and with that you can do anything else using zig build |
Indeed :-) |
If you agree with this, then it would make sense that building documentation is not part of getting a fully functional zig and it should be done with |
I'm currently packaging zig for Fedora. As a packager, I see value in the doc installation step, but in the end it's up to you and no big deal to me to do it explicitly if upstream is not interested ;-) |
you can build the docs just fine for a fedora package |
We will have this eventually, but it will not be via cmake. A |
This should fix #7897