macho: upstream zld linker #8282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix debug info for static archives * allow handling of empty object files * fix some relocs for GOT loads
kubkon
added
os-macos
frontend
|
I just wanted to point out that we pass all tests on Apple Silicon with the exception of a few standalone tests producing or linking against shared libraries, and there seems to be an issue with alignment when running translate-c test suite. Apart from that, we are green with the rest of the test suite! |
kivikakk
added a commit
to kivikakk/libpcre.zig
that referenced
this pull request
Mar 25, 2021
ziglang/zig#8282 has changed how this works and it breaks right now.
kivikakk
added a commit
to kivikakk/koino
that referenced
this pull request
Mar 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is upstreaming
zld, the traditional linker, as a drop-in replacement for LLD when targeting MachO.zldis now currently used by default when cross-compiling Zig and C (C++ to join the club soon-ish), and it's the default linker foraarch64. This is a bold step, but @andrewrk and myself believe definitely worth a try even thoughzldis not fully functional yet and bugs are to be expected. However, we do believe this way we'll get bugs weed out much quicker and thus progress the linker development much faster. Also, a bonus for usingzldis the fact that TLV is finally properly handled on Apple Silicon in Zig!Fixes #8216
Fixes #7527
Fixes #6971