Segmented list implementation #992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thejoshwolfe
approved these changes
May 7, 2018
std/segmented_list.zig
Outdated
| pub fn SegmentedList(comptime T: type, comptime prealloc_item_count: usize) type { | ||
| return struct { | ||
| const Self = this; | ||
| const prealloc_base = blk: { |
There was a problem hiding this comment.
isn't this more of an exponent than a base?
| allocator: &Allocator, | ||
| len: usize, | ||
| prealloc_segment: [prealloc_item_count]T, | ||
| dynamic_segments: []&T, |
There was a problem hiding this comment.
After pointer reform, this will be [][*]T, right?
| /// Note however that most elements are contiguous, making this data structure cache-friendly. | ||
| /// | ||
| /// Because it never has to copy elements from an old location to a new location, it does not require | ||
| /// its elements to be copyable, and it avoids wasting memory when backed by an ArenaAllocator. |
There was a problem hiding this comment.
But push() and pop() do require the item be copyable. You might want to say that you can use addOne(), at(), and ... shrinkCapacity()? if you actually want to avoid copying items.
std/segmented_list.zig
Outdated
| return struct { | ||
| const Self = this; | ||
| const prealloc_base = blk: { | ||
| assert(prealloc_item_count != 0); |
There was a problem hiding this comment.
i think i understand how this assertion doesn't trip when it actually is 0. because this constant is never used, so the compiler never needs to compute it's value. that definitely needs a comment like "if we get here, then this value is being used" or something.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #986.