-
Notifications
You must be signed in to change notification settings - Fork 675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove LevelControl
cluster for TRADFRI plug
#2594
Conversation
The original quirk was doing it but later firmware have change the signature so it was not working.
For historical information on firmware 2.3.089 the signature is without quirk:
|
LevelControl
cluster for TRADFRI plug
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev #2594 +/- ##
=======================================
Coverage 86.54% 86.54%
=======================================
Files 276 276
Lines 8502 8505 +3
=======================================
+ Hits 7358 7361 +3
Misses 1144 1144
☔ View full report in Codecov by Sentry. |
This will mark all |
I dont need it but some users is not liking not working GUI entries and its looks working OK after deleting and adding the plug new (so ZHA is deleting the old cluster in the DB). |
Thanks J |
Proposed change
This removes the
LevelControl
cluster for the IKEA TRADFRI plug to not create theon_level
and other settings entities in ZHA, as that can cause confusion about whether or not the on/off plug is a dimmer.Additional information
The original quirk for older firmware already removed the
LevelControl
cluster. This PR also does it for newer firmware versions.See home-assistant/core#100454 for context
Checklist
pre-commit
checks pass / the code has been formatted using Black